Omer Frenkel has posted comments on this change.
Change subject: core: AddVM - Show an Event when exeeding the mem range
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
Line 354: * @return
Line 355: */
Line 356: public static void warnMemorySizeLegal(VmBase vm, Version
clusterVersion) {
Line 357: if (! VmValidationUtils.isMemorySizeLegal(vm.getOsId(),
vm.getMemSizeMb(), clusterVersion)) {
Line 358: AuditLogableBase logable = new AuditLogableBase();
please set the vm id to the logable object so it would appear under the vm's
events sub tab
Line 359: logable.addCustomValue("VmName", vm.getName());
Line 360: logable.addCustomValue("VmMemInMb",
String.valueOf(vm.getMemSizeMb()));
Line 361: logable.addCustomValue("VmMinMemInMb",
Line 362:
String.valueOf(VmValidationUtils.getMinMemorySizeInMb(vm.getOsId(),
clusterVersion)));
--
To view, visit http://gerrit.ovirt.org/21219
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52067ea090bb8d3b239b4dd8a6ac0b5188dbdc20
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
