Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Disable Rebalance/Remove Brick when one or more bricks are down ......................................................................
Patch Set 4: Code-Review+1 (1 comment) 1 small comment on type of error .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java Line 733: ACTION_TYPE_FAILED_GLUSTER_VOLUME_NAME_ALREADY_EXISTS(ErrorType.CONFLICT), Line 734: ACTION_TYPE_FAILED_GLUSTER_VOLUME_INVALID(ErrorType.BAD_PARAMETERS), Line 735: ACTION_TYPE_FAILED_BRICKS_REQUIRED(ErrorType.BAD_PARAMETERS), Line 736: ACTION_TYPE_FAILED_BRICK_ID_REQUIRED(ErrorType.BAD_PARAMETERS), Line 737: ACTION_TYPE_FAILED_ONE_OR_MORE_BRICKS_ARE_DOWN(ErrorType.BAD_PARAMETERS), Should it be conflict? Line 738: ACTION_TYPE_FAILED_GLUSTER_BRICK_INVALID(ErrorType.BAD_PARAMETERS), Line 739: ACTION_TYPE_FAILED_REPLICA_COUNT_MIN_2(ErrorType.CONFLICT), Line 740: ACTION_TYPE_FAILED_REPLICA_COUNT_MIN_4(ErrorType.CONFLICT), Line 741: ACTION_TYPE_FAILED_INVALID_BRICK_COUNT_FOR_REPLICATE(ErrorType.BAD_PARAMETERS), -- To view, visit http://gerrit.ovirt.org/19984 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib66fe531dfea6099a449fcae8c4370711ae3dd8b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
