Omer Frenkel has posted comments on this change.
Change subject: core: Host shouldn't move to UP if it's already connected to
other pool
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 221:
getStorageDomainDAO().getStorageDomainByTypeAndPool(storagePoolId,
StorageDomainType.Master);
Line 222: boolean masterDomainInactiveOrUnknown =
masterDomain.getStatus() == StorageDomainStatus.InActive
Line 223: || masterDomain.getStatus() ==
StorageDomainStatus.Unknown;
Line 224:
Line 225: VDSReturnValue returnValue =
ResourceManager.getInstance().runVdsCommand(VDSCommandType.ConnectStoragePool,
i dont know why you are using this, but basically its wrong, the resource
manger should be an independent component, and the instance shouldn't be called
from outside its package.
i looked now and i see other usages of this, which is bad that we missed that.
the resource manger package has a 'frontend' class in the bll that should be
used.
Line 226: new
ConnectStoragePoolVDSCommandParameters(vds.getId(), storagePoolId,
Line 227: vds.getVdsSpmId(), masterDomain.getId(),
Line 228: storagePool.getmaster_domain_version()));
Line 229: if (!returnValue.getSucceeded()) {
--
To view, visit http://gerrit.ovirt.org/21095
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd3d8268516b010f7831b59bbc6331cfd70efec1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
