Vojtech Szocs has posted comments on this change. Change subject: webadmin: fix feedback image visiblity issue ......................................................................
Patch Set 2: Code-Review+2 (1 comment) Nice patch! .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/HeaderPresenterWidget.java Line 26 Line 27 Line 28 Line 29 Line 30 +1 Good thing you've changed this method! In general, ViewDef interface shouldn't have any reference to specific GWT widgets like Label - it should have either methods like this: void usedToUpdateView(params...); or this: HasSomeHandlers usedToRegisterHandlersOnView(); This is to allow easy testing of Presenter(Widget) via classic unit tests, i.e. ViewDef has no reference to GWT widgets so we don't need GwtTestCase stuff. I know, we don't have such tests today, but it's good to keep ViewDef "clean" and GWT-agnostic anyway. -- To view, visit http://gerrit.ovirt.org/21084 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08c673909ba2a1c13e6bcac70a3ff19a99a1e6a3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
