Hello Yair Zaslavsky,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21304
to review the following change.
Change subject: core: Extracting addMixin method
......................................................................
core: Extracting addMixin method
This method is extracted for future testing
purposes
Change-Id: Ieca1adc66268e79e45879d179249047940defbae
Signed-off-by: Yair Zaslavsky <[email protected]>
---
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializer.java
1 file changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/04/21304/1
diff --git
a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializer.java
b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializer.java
index c190589..d3d4cb2 100644
---
a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializer.java
+++
b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializer.java
@@ -32,20 +32,17 @@
private static final ObjectMapper formattedMapper;
static {
formattedMapper = new ObjectMapper();
-
formattedMapper.getDeserializationConfig().addMixInAnnotations(Guid.class,
JsonGuidMixIn.class);
-
formattedMapper.getDeserializationConfig().addMixInAnnotations(VdcActionParametersBase.class,
- JsonVdcActionParametersBaseMixIn.class);
-
formattedMapper.getDeserializationConfig().addMixInAnnotations(IVdcQueryable.class,
- JsonIVdcQueryableMixIn.class);
-
formattedMapper.getDeserializationConfig().addMixInAnnotations(VM.class,
JsonVmMixIn.class);
-
formattedMapper.getDeserializationConfig().addMixInAnnotations(VdsStatic.class,
JsonVdsStaticMixIn.class);
-
formattedMapper.getDeserializationConfig().addMixInAnnotations(VDS.class,
JsonVDSMixIn.class);
-
formattedMapper.getDeserializationConfig().addMixInAnnotations(AddVmTemplateParameters.class,
- JsonAddVmTemplateParametersMixIn.class);
-
formattedMapper.getDeserializationConfig().addMixInAnnotations(VmManagementParametersBase.class,
+ addMixin(Guid.class, JsonGuidMixIn.class);
+ addMixin(VdcActionParametersBase.class,
JsonVdcActionParametersBaseMixIn.class);
+ addMixin(IVdcQueryable.class, JsonIVdcQueryableMixIn.class);
+ addMixin(VM.class, JsonVmMixIn.class);
+ addMixin(VdsStatic.class, JsonVdsStaticMixIn.class);
+ addMixin(VDS.class, JsonVDSMixIn.class);
+ addMixin(AddVmTemplateParameters.class,
JsonAddVmTemplateParametersMixIn.class);
+ addMixin(VmManagementParametersBase.class,
JsonVmManagementParametersBaseMixIn.class);
-
formattedMapper.getDeserializationConfig().addMixInAnnotations(VmBase.class,
JsonVmBaseMixIn.class);
-
formattedMapper.getDeserializationConfig().addMixInAnnotations(VmStatic.class,
JsonVmStaticMixIn.class);
+ addMixin(VmBase.class, JsonVmBaseMixIn.class);
+ addMixin(VmStatic.class, JsonVmStaticMixIn.class);
formattedMapper.configure(Feature.FAIL_ON_UNKNOWN_PROPERTIES, false);
formattedMapper.enableDefaultTyping();
}
@@ -57,6 +54,9 @@
public JsonObjectDeserializer() {
}
+ public static void addMixin(Class<?> targetClass, Class<?> mixinClass) {
+
formattedMapper.getDeserializationConfig().addMixInAnnotations(targetClass,
mixinClass);
+ }
@Override
public <T extends Serializable> T deserialize(Object source, Class<T>
type) throws SerializationExeption {
--
To view, visit http://gerrit.ovirt.org/21304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieca1adc66268e79e45879d179249047940defbae
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
