Vered Volansky has posted comments on this change.
Change subject: engine: Simplify AddStorageDomainCommand.conectStorage
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
Line 127:
Line 128: protected Pair<Boolean, Integer> connectStorage() {
Line 129: String connectionId = getStorageDomain().getStorage();
Line 130: StorageServerConnections connection =
getStorageServerConnectionDAO().get(connectionId);
Line 131: List<StorageServerConnections> connections =
Arrays.asList(connection);
Just a matter of naming - I don't like the fact that you're switching from
singular to plural (connection --> connections). Should be plural all the way
IMO.
Line 132:
Line 133: Map<String, String> result = (HashMap<String, String>)
runVdsCommand(
Line 134: VDSCommandType.ConnectStorageServer,
Line 135: new
StorageServerConnectionManagementVDSParameters(getParameters().getVdsId(),
--
To view, visit http://gerrit.ovirt.org/21321
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80beec8f08b0e6fa397177bfb00b4b4cb2570348
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
