Allon Mureinik has posted comments on this change.
Change subject: engine: Remove StorageType.ALL value
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
see inline
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVGListVDSCommand.java
Line 53: }
Line 54: if (vg.containsKey("vgtype")) {
Line 55:
sDomain.setStorageType(EnumUtils.valueOf(StorageType.class,
vg.get("vgtype").toString(), true));
Line 56: } else {
Line 57: sDomain.setStorageType(StorageType.UNKNOWN);
The only place I can see that uses this VDS command is GetVgListQuery, which
filters out anything that isn't a block domain.
That being said, it may be a good defensive practice to have an upgrade script,
just so that the DAO layer does not fail on translating some old data to the
enum.
Line 58: }
Line 59: result.add(sDomain);
Line 60: }
Line 61: return result;
--
To view, visit http://gerrit.ovirt.org/21315
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I761d322f88304353bb11fceeed39305dd6698045
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
