Tal Nisan has submitted this change and it was merged. Change subject: engine, restapi: Remove redundant SizeConverter ......................................................................
engine, restapi: Remove redundant SizeConverter Engine has 2 implementations of SizeConverter utility which converts disk size from one unit to another. One of those implementations resides in the common code and its code looks elegant therefore its chosen to stay while other has been deleted. Change-Id: I6a82a4a2ac199eb226b8848ac579106ca0497669 Signed-off-by: Sergey Gotliv <[email protected]> --- A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/SizeConverterTest.java D backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/SizeConverter.java D backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/util/SizeConverterTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapper.java 5 files changed, 66 insertions(+), 121 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a82a4a2ac199eb226b8848ac579106ca0497669 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
