Alissa Bonas has uploaded a new change for review. Change subject: core: rename sortCommands method in *Runner classes. ......................................................................
core: rename sortCommands method in *Runner classes. Rename to lowercase to solve findbug warning. Change-Id: I35712f0ee4b8d88e218ea1f4416398743f1cfdfa Signed-off-by: Alissa Bonas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVMActionRunner.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVMActionRunner.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SortedMultipleActionsRunnerBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainsMultipleActionRunner.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainsMultipleActionRunner.java 5 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/37/21337/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVMActionRunner.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVMActionRunner.java index 3627b53..f76568f 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVMActionRunner.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVMActionRunner.java @@ -22,7 +22,7 @@ } @Override - protected void SortCommands() { + protected void sortCommands() { ArrayList<CommandBase<?>> commands = getCommands(); final Map<Guid, VM> vms = new HashMap<Guid, VM>(commands.size()); for (CommandBase<?> cmd : commands) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVMActionRunner.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVMActionRunner.java index 4d7a768..995f7ca 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVMActionRunner.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVMActionRunner.java @@ -16,7 +16,7 @@ } @Override - protected void SortCommands() { + protected void sortCommands() { ArrayList<CommandBase<?>> commandsList = getCommands(); HashMap<Guid, RunVmCommandBase<?>> runVmCommandsMap = new HashMap<Guid, RunVmCommandBase<?>>(); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SortedMultipleActionsRunnerBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SortedMultipleActionsRunnerBase.java index 9f55122..8b8968c 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SortedMultipleActionsRunnerBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SortedMultipleActionsRunnerBase.java @@ -9,11 +9,11 @@ super(actionType, parameters, isInternal); } - protected abstract void SortCommands(); + protected abstract void sortCommands(); @Override protected void RunCommands() { - SortCommands(); + sortCommands(); super.RunCommands(); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainsMultipleActionRunner.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainsMultipleActionRunner.java index c96ec8f..62dc3fc 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainsMultipleActionRunner.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainsMultipleActionRunner.java @@ -52,13 +52,13 @@ } @Override - protected void SortCommands() { + protected void sortCommands() { Collections.sort(getCommands(), new StorageDomainsByTypeComparer()); } @Override protected void RunCommands() { - SortCommands(); + sortCommands(); for (final CommandBase<?> command : getCommands()) { if (command.getReturnValue().getCanDoAction()) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainsMultipleActionRunner.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainsMultipleActionRunner.java index c663136..bd74071 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainsMultipleActionRunner.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainsMultipleActionRunner.java @@ -13,7 +13,7 @@ } @Override - protected void SortCommands() { + protected void sortCommands() { Collections.sort(getCommands(), Collections.reverseOrder(new StorageDomainsByTypeComparer())); } } -- To view, visit http://gerrit.ovirt.org/21337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I35712f0ee4b8d88e218ea1f4416398743f1cfdfa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
