Kanagaraj M has posted comments on this change.
Change subject: gluster: consider rebalance fail in stop rebalance
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRebalanceGlusterVolumeCommand.java
Line 65: GlusterVolumeTaskStatusEntity rebalanceStatusEntity =
Line 66: (GlusterVolumeTaskStatusEntity)
vdsReturnaValue.getReturnValue();
Line 67: JobExecutionStatus stepStatus =
rebalanceStatusEntity.getStatusSummary().getStatus();
Line 68: if (JobExecutionStatus.FINISHED == stepStatus ||
JobExecutionStatus.FAILED == stepStatus) {
Line 69: endStepJob(stepStatus, getStepMessageMap(stepStatus),
true);
you are passing 'true' to 'exitStatus' in case of FAILED as well.
Line 70: } else {
Line 71: endStepJob(JobExecutionStatus.ABORTED,
getStepMessageMap(JobExecutionStatus.ABORTED), false);
Line 72: }
Line 73: releaseVolumeLock();
--
To view, visit http://gerrit.ovirt.org/21339
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I147c43c6925b8a52cf8a7667a5d7f101969f5368
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
