Daniel Erez has posted comments on this change.
Change subject: webadmin: Fixed event listener assignment (Findbugs)
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.java
Line 169: public void eventRaised(Event ev, Object sender,
EventArgs args) {
Line 170: getSelectionModel(topTableIsEdited).clear();
Line 171: }
Line 172: };
Line 173: if (topTableIsEdited) {
Isn't it simpler/nicer to create two static listeners in advance and use them
accordingly?
Line 174: topItemsChangedListener = listener;
Line 175: } else {
Line 176: bottomItemsChangedListener = listener;
Line 177: }
--
To view, visit http://gerrit.ovirt.org/21342
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35bb5fb094168e44bd77f4847067aa94b7c1fe22
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
