Sahina Bose has posted comments on this change. Change subject: engine: cleanup AddVdsCommand locking ......................................................................
Patch Set 3: (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java Line 346 Line 347 Line 348 Line 349 Line 350 Yes, I had in fact, introduced a similar check in InitVdsOnUpCommand, to make sure that host does not get added if none of the servers are Up. Would prefer having the check in both places, as we would rather fail the installation in the beginning if the condition is not met than wait for vdsm to come up. I will move the check to a common place to reuse. -- To view, visit http://gerrit.ovirt.org/18350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6189d7f0046a943a58db9d6734c92fe462c9db52 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
