Ori Liel has posted comments on this change.
Change subject: core, engine, webadmin: Initial support for alternative
architectures
......................................................................
Patch Set 14:
(2 comments)
One comment in VmMapper, other than that - restapi part looks good.
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
Line 149: }
Line 150: if (vm.getCpu().isSetCpuTune()) {
Line 151:
staticVm.setCpuPinning(cpuTuneToString(vm.getCpu().getCpuTune()));
Line 152: }
Line 153:
Why no mapping of cpu architecture here? In comparison, ClusterMapper and
TemplateMapper have this mapping.
Line 154: }
Line 155: if (vm.isSetCpuShares()) {
Line 156: staticVm.setCpuShares(vm.getCpuShares());
Line 157: }
Line 346: cpu.setMode(CpuMode.HOST_PASSTHROUGH.value());
Line 347: }
Line 348: cpu.setCpuTune(stringToCpuTune(entity.getCpuPinning()));
Line 349: cpu.setTopology(topology);
Line 350:
whitespace
Line 351: model.setCpuShares(entity.getCpuShares());
Line 352:
Line 353: cpu.setArchitecture(CPUMapper.map(entity.getClusterArch(),
null));
Line 354:
--
To view, visit http://gerrit.ovirt.org/18938
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ecd642e2bc05067d55884c948bdaeb6e7838c26
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
