Kanagaraj M has posted comments on this change.
Change subject: webadmin : remove-brick status error handling
......................................................................
Patch Set 9:
(2 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java
Line 1316: onAddBricksInternal();
Line 1317: } else if (command.getName().equals("CancelConfirmation")) {
//$NON-NLS-1$
Line 1318: cancelConfirmation();
Line 1319: } else
if(command.getName().equals("CancelRemoveBrickStatusNotAvailable")){//$NON-NLS-1$
Line 1320: cancelConfirmation();
no need to have another else, use the same name "CancelConfirmation" for the
your cancel command also.
Line 1321: } else if (command.equals(getRemoveBricksCommand())) {
Line 1322: removeBricks();
Line 1323: } else if (command.getName().equals("OnRemove")) {
//$NON-NLS-1$
Line 1324: onRemoveBricks();
Line 1351: } else if (command.equals(getBrickAdvancedDetailsCommand()))
{
Line 1352: showBrickAdvancedDetails();
Line 1353: } else if (command.getName().equals("Cancel")) {
//$NON-NLS-1$
Line 1354: setWindow(null);
Line 1355: } else if (command.getName().equals("CancelConfirmation")) {
//$NON-NLS-1$
This is duplicate of above
Line 1356: cancelConfirmation();
Line 1357: }
Line 1358:
Line 1359: }
--
To view, visit http://gerrit.ovirt.org/21086
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57bb82ebc0318266f32262c6f9bb245e26f2ddd1
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
