Vojtech Szocs has posted comments on this change.
Change subject: core: Add no-argument constructor check
......................................................................
Patch Set 1:
@Allon - I have one more idea for you to consider, please let me know what you
think.
There are some classes in "common" module for which adding no-arg constructor
seems just artificial/redundant (none of these classes have relation to GWT
RPC):
* test classes
* utility classes like PredicateFilter and MapBackedPreferences
So we might end up trying to do this:
public class MapBackedPreferences ... {
...
public MapBackedPreferences(AbstractPreferences parent, String name) {
super(parent, name); // original code
}
private MapBackedPreferences() {
// need to call super, which params to use? (use nulls?)
}
...
}
Instead, we could disable NoArgConstructorCheck per class like this:
@NoArgConstructorCheck.Disable
public class MapBackedPreferences ...
There aren't many classes like this in "common" module, but for those few,
adding no-arg constructor "by force" will surely leave some backend maintainers
scratching their heads and thinking why is this constructor there.
So what do you think about @NoArgConstructorCheck.Disable approach? (I already
have a working implementation for that.)
--
To view, visit http://gerrit.ovirt.org/20274
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4f9a00d6289374b433ed4419552420a3337da50
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
