Kanagaraj M has posted comments on this change.
Change subject: engine : Rebalance status to show Started and Stopped At fields
......................................................................
Patch Set 8:
(6 comments)
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
Line 3:
Line 4: import org.ovirt.engine.core.common.businessentities.VmPool;
Line 5:
Line 6: import com.google.gwt.i18n.client.Constants.DefaultStringValue;
Line 7:
I don't see any changes to this file
Line 8: public interface UIConstants extends
com.google.gwt.i18n.client.Constants {
Line 9:
Line 10: @DefaultStringValue("OK")
Line 11: String ok();
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 1: package org.ovirt.engine.ui.webadmin;
Line 2:
Line 3: import org.ovirt.engine.ui.common.CommonApplicationConstants;
Line 4:
Line 5: import com.google.gwt.i18n.client.Constants.DefaultStringValue;
does this import required?
Line 6:
Line 7: public interface ApplicationConstants extends
CommonApplicationConstants {
Line 8:
Line 9: @DefaultStringValue("oVirt Engine Web Administration")
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java
Line 79:
Line 80: @UiField
Line 81: @Ignore
Line 82: @WithElementId
Line 83: VerticalPanel vPanel2;
provide some meaningful names
Line 84:
Line 85: @UiField
Line 86: @Ignore
Line 87: @WithElementId
Line 94:
Line 95: @UiField
Line 96: @Ignore
Line 97: @WithElementId
Line 98: SimpleDialogPanel sdPanel;
same here
Line 99:
Line 100: @UiField
Line 101: @Ignore
Line 102: Label messageLabel;
Line 101: @Ignore
Line 102: Label messageLabel;
Line 103:
Line 104: @Path("stopTime.entity")
Line 105: EntityModelLabelEditor stopTime;
this is not a uifield?
Line 106:
Line 107: ApplicationMessages messages;
Line 108:
Line 109: ApplicationConstants constants;
Line 223:
completedStatus.setVisible(object.isStatusAvailable());
Line 224: status.add(completedStatus);
Line 225: } else
if(e.PropertyName.equals("IS_STOP_TIME_APPLICABLE")) {//$NON-NLS-1$
Line 226: sdPanel.setSize("1000px",
"550px");//$NON-NLS-1$//$NON-NLS-2$
Line 227: sPanel.setSize("981px",
"415px");//$NON-NLS-1$//$NON-NLS-2$
Its better not to re-size the dialog, once it is opened
Line 228:
Line 229: vPanel2.remove(clusterEditor);
Line 230: vPanel2.remove(statusTimeEditor);
Line 231:
--
To view, visit http://gerrit.ovirt.org/20800
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2957ba2c4bd1f6deb1ef444e28e8afdd8896f0b4
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
