Yair Zaslavsky has posted comments on this change.
Change subject: core: Failed to run VM with boot order of CD and DISK
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Although small change - this is something we should pay attention to in general
(and maybe do some iteration on all our business entities and check this).
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
Line 1531: public boolean isRunOnce() {
AFAIK, not java bean convention (not saying we "excel" on this issue) - this
may cause problems with various java frameworks.
setter name should be - setRunOnce
getter should be - isRunOnce
--
To view, visit http://gerrit.ovirt.org/3894
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df87e234a588f37f837cb47be9c6efb425fbd6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
