Martin Peřina has posted comments on this change.
Change subject: core: Add Keystone authenticator
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/openstack/KeystoneAuthenticator.java
Line 61: /**
Line 62: * {@inheritDoc}
Line 63: */
Line 64: @Override
Line 65: public boolean authenticate(String user, char[] password) {
Please add result variable and return its value instead of two return places
Line 66: // Create the authentiction request:
Line 67: TokensResource.Authenticate request =
client.tokens().authenticate()
Line 68: .withUsernamePassword(user, new String(password))
Line 69: .withTenantName(tenant);
--
To view, visit http://gerrit.ovirt.org/21149
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9588f015ac8766e38163665e4eec68b9d5638a6d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
