Martin Peřina has posted comments on this change.
Change subject: core: Add remote user authenticator
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/remote/RemoteUserAuthenticator.java
Line 1: package org.ovirt.engine.core.authentication.remote;
Line 2:
Line 3: import static org.apache.commons.lang.StringUtils.isEmpty;
Please use static imports only for constants
Line 4:
Line 5: import javax.servlet.http.HttpServletRequest;
Line 6: import javax.servlet.http.HttpServletResponse;
Line 7:
Line 77: @Override
Line 78: public NegotiationResult negotiate(HttpServletRequest req,
HttpServletResponse rsp) {
Line 79: // Get the value of the REMOTE_USER CGI environment variable,
if it isn't available send a warning explaining
Line 80: // that the web server or the application server may not be
correctly configured:
Line 81: String value = req.getRemoteUser();
Is it worth to store req.getRemoteUser() to attribute value when it's used only
in isEmpty() call?
Line 82: if (isEmpty(value)) {
Line 83: log.warn(
Line 84: "Can't authenticate the user because the REMOTE_USER
CGI environment variable isn't available, check" +
Line 85: "the configuration of the web server and the
application server."
--
To view, visit http://gerrit.ovirt.org/21299
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0856ac9b9631f3b25eff4a9c93bb548727c74587
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
