Einav Cohen has posted comments on this change. Change subject: webadmin: change search to be case-insensitive ......................................................................
Patch Set 1: Code-Review+1 I don't mind the 'true' default value within SearchableListModel - just wanted to verify that indeed the 'false' value set by the common model is the one that eventually being applied - thanks for the explanation. The patch looks OK to me, but I'd rather that people that are more familiar with uicommon will review it as well - adding Derez/Gilad, in a hope that they will be able to assist here. Thanks. -- To view, visit http://gerrit.ovirt.org/21213 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2c5f48cf565533c330c80a02ee24596ee039e2d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
