Sahina Bose has posted comments on this change.
Change subject: gluster: Update task status while querying rebalance status
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRebalanceStatusQuery.java
Line 74:
Line 75: // release the volume lock if the task is completed
Line 76: if (getGlusterTaskUtils().hasTaskCompleted(asyncTask))
{
Line 77: getGlusterTaskUtils().releaseLock(volume.getId());
Line 78: }
The common logic can be moved out. I would suggest to extend both
RemoveBrickStatus and RebalanceStatus from a common class
Line 79: }
Line 80: }
Line 81:
Line 82: // Set the host ip in status details
--
To view, visit http://gerrit.ovirt.org/21069
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I375c0156fe60bd9473889abce51ad93366bc9d40
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
