Frank Kobzik has posted comments on this change. Change subject: frontend: Refactored UnitVmModel to support generics ......................................................................
Patch Set 3: Code-Review+1 (1 comment) (just one minor comment completely not related to the code :) ) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java Line 1290: setIsDisplayTabValid(getIsAllocationTabValid()); Line 1291: setIsFirstRunTabValid(getIsDisplayTabValid()); Line 1292: setIsGeneralTabValid(getIsFirstRunTabValid()); Line 1293: Line 1294: // NOTE: This is because currently the auto generated view code tries to register events of just nitpicking, but "pooltype" has disappeared. Line 1295: // for Line 1296: // VM/Template views as this model is shared across VM/Template/Pool models Line 1297: setPoolType(new NotChangableForVmInPoolListModel<EntityModel<VmPoolType>>()); Line 1298: -- To view, visit http://gerrit.ovirt.org/21298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8d177bca97bd0eb31bfcd57d25a481b65485b71 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
