Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: config broker notifications ......................................................................
Patch Set 6: (2 comments) .................................................... File src/ovirt_hosted_engine_setup/constants.py Line 527: Line 528: DEFAULT_SMTP_SERVER = 'localhost' Line 529: DEFAULT_SMTP_PORT = 25 Line 530: DEFAULT_SOURCE_EMAIL = 'root' Line 531: DEFAULT_DEST_EMAIL = 'root' It's not strictly required - local mta will canonify it. It is required, though, because in the code we require '@'... Thanks! Line 532: Line 533: Line 534: @util.export Line 535: @util.codegen .................................................... File src/plugins/ovirt-hosted-engine-setup/ha/ha_notifications.py Line 67: ) Line 68: Line 69: _RE_EMAIL_ADDRESS = re.compile( Line 70: flags=re.VERBOSE, Line 71: pattern=r""" Already discussed this on the bug. I'd rather be conservative now and not deal with quoting/utf-8/whatever if I do not have to. I do not believe any sane admin will want to get notifications to a "smart" address. Ahh, we do want to add '+', the semi-standard address extension. Line 72: [a-zA-Z0-9_.]+ Line 73: @ Line 74: [a-z0-9.-]+ Line 75: """ -- To view, visit http://gerrit.ovirt.org/21415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib49f0534b5f8a9918558a82d40cc9828ccf87868 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
