Sergey Gotliv has posted comments on this change. Change subject: core: fix possible NPE on import VM with ram snapshot ......................................................................
Patch Set 1: (1 comment) .................................................... Commit Message Line 9: In case the memory volumes are set to be imported to storage domain that Line 10: no disk was set to be imported to, we were getting NPE in Line 11: ImportVmCommand#setDomainsForMemoryImages since we assumed that the Line 12: storage domain exists in domain2requiredSize map but it doesn't exists Line 13: there in that case. What do you mean by "that case"? VM doesn't have disks? Line 14: Line 15: So from now on we will check whether the storage domain that the memory Line 16: volumes are going to be imported to exists in domain2requiredSize or Line 17: not and act accordingly in ImportVmCommand#setDomainsForMemoryImages. -- To view, visit http://gerrit.ovirt.org/21450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a574266bdf6f06b7906c1338428071094430a9b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
