Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: add force support to add-bricks
......................................................................
Patch Set 6:
(3 comments)
Minor comments
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1541:
Line 1542: @TypeConverterAttribute(Boolean.class)
Line 1543: @DefaultValueAttribute("true")
Line 1544: GlusterSupportForceCreateVolume,
Line 1545:
Entry for add brick as well ??
Line 1546: Invalid;
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/gluster/GlusterFeatureSupported.java
Line 73: * @return <code>true</code> if there's support for force option
in Create Volume, <code>false</code> if it's not.
Line 74: */
Line 75: public static boolean glusterForceCreateVolumeSupported(Version
version) {
Line 76: return
supportedInConfig(ConfigValues.GlusterSupportForceCreateVolume, version);
Line 77: }
For add brick ??
....................................................
File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 150: select fn_db_add_config_value('GlusterSupport', 'false', '3.0');
Line 151: select fn_db_add_config_value('GlusterSupportForceCreateVolume',
'false', '3.0');
Line 152: select fn_db_add_config_value('GlusterSupportForceCreateVolume',
'false', '3.1');
Line 153: select fn_db_add_config_value('GlusterSupportForceCreateVolume',
'false', '3.2');
Line 154: select fn_db_add_config_value('GlusterSupportForceCreateVolume',
'false', '3.3');
Do we need separate configurations for add bricks as well here ?
Line 155: select
fn_db_add_config_value('GlusterVolumeOptionGroupVirtValue','virt','general');
Line 156: select
fn_db_add_config_value('GlusterVolumeOptionOwnerUserVirtValue','36','general');
Line 157: select
fn_db_add_config_value('GlusterVolumeOptionOwnerGroupVirtValue','36','general');
Line 158: select fn_db_add_config_value('GlusterRefreshRateTasks', '60',
'general');
--
To view, visit http://gerrit.ovirt.org/21403
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65b3e96d759a0b09b625da793b6c63b93f8c2131
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
