Eoghan Glynn has posted comments on this change. Change subject: restapi: Mappers for Gluster entities ......................................................................
Patch Set 4: Looks good to me, but someone else must approve Hi Shireesh, Looks good. Ori caught a lot of small discrepancies from convention in his thorough review of patch set 2, and it looks like you've addressed this feedback in the latest patch set. I'm gratified to see the AbstractInvertibleMappingTest still being used as intended nearly two years after it was written ;) Cheers, Eoghan -- To view, visit http://gerrit.ovirt.org/3385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I364d853106eda1a956241eb7210ce85781ee88b9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Eoghan Glynn <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
