Omer Frenkel has posted comments on this change.
Change subject: engine: Gluster syncing lock correction- change cluster
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
Line 233: private boolean glusterHostAdd(Guid targetClusterId) {
Line 234: // If "gluster peer probe" and "gluster peer status" are
executed simultaneously, the results
Line 235: // are unpredictable. Hence locking the cluster to ensure the
sync job does not lead to race
Line 236: // condition.
Line 237: try (EngineLock lock =
GlusterUtil.getInstance().acquireGlusterLockWait(targetClusterId)) {
since lock is autoclosable it should be released automatically, no?
Line 238: String hostName =
Line 239: (getVds().getHostName().isEmpty()) ?
getVds().getManagementIp()
Line 240: : getVds().getHostName();
Line 241: VDS runningHostInTargetCluster =
getClusterUtils().getUpServer(targetClusterId);
--
To view, visit http://gerrit.ovirt.org/20647
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe28b5eb5baee573f0fa875e06d7ae945ffdb9f9
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
