Daniel Erez has posted comments on this change.
Change subject: frontend: changes in add permissions popup
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserPortalAdElementListModel.java
Line 33: @Override
Line 34: public void onSuccess(Object model, Object result) {
Line 35: populateDomains((List<String>) result);
Line 36: }
Line 37: }), true, false);
Try overriding only the flag (currentDomainOnly) instead of the entire method.
E.g. extract it to isCurrentDomainOnly method.
Line 38:
Line 39: }
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
Line 744:
getSysPrepDomainName().setSelectedItem(selectedDomain);
Line 745: }
Line 746: }
Line 747: }),
Line 748: false,
shouldn't it be updated in UserPortalRunOnceModel as well?
Line 749: true);
Line 750: }
Line 751:
Line 752: @Override
--
To view, visit http://gerrit.ovirt.org/16036
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6084b6b100c5fbb39a9d7738661bad69b3aaa8e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
