Ravi Nori has posted comments on this change.
Change subject: engine: Add infrastructure code for removal of parameter classes
......................................................................
Patch Set 16:
(2 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VdcParametersMap.java
Line 11: public class VdcParametersMap implements Serializable {
Line 12: private static final long serialVersionUID = 4872560145516614775L;
Line 13:
Line 14: @JsonProperty("paramsMap")
Line 15: private HashMap<VdcParameter, Serializable> paramsMap;
Map<VdcParameter, Object> cant be serialized by GWT. Needs to be
HashMap<VdcParameter, Serializable>
Line 16:
Line 17: public VdcParametersMap() {
Line 18: paramsMap = new HashMap<VdcParameter, Serializable>();
Line 19: }
Line 18: paramsMap = new HashMap<VdcParameter, Serializable>();
Line 19: }
Line 20:
Line 21: public VdcParametersMap put(VdcParameter param, Object value) {
Line 22: paramsMap.put(param, (Serializable) value);
Parameter type validation is done at canDoAction stage of the command. Cant
validate here GWT does not have isAssignable from
Line 23: return this;
Line 24: }
Line 25:
Line 26: public <T> T get(VdcParameter param) {
--
To view, visit http://gerrit.ovirt.org/20414
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a0970e492c0eff561888a46b02e47645ff68fc3
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
