Kanagaraj M has submitted this change and it was merged. Change subject: engine: cleanup AddVdsCommand locking ......................................................................
engine: cleanup AddVdsCommand locking AddVdsCommand was overriding getExclusiveLocks to lock the cluster if cluster supports gluster service. But this is not required here as the "gluster peer probe" which requires the lock only happens after the host comes up. Removed the code which does a "gluster peer probe" in case ConfigValues.InstallVds = true. This code gets executed as InitVdsOnUpCommand and is not required here. Change-Id: I6189d7f0046a943a58db9d6734c92fe462c9db52 Bug-Url: https://bugzilla.redhat.com/998799 Signed-off-by: Sahina Bose <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java 1 file changed, 2 insertions(+), 50 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/18350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6189d7f0046a943a58db9d6734c92fe462c9db52 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
