Itamar Heim has posted comments on this change. Change subject: sdk: Add debug logging of the HTTP messages ......................................................................
Patch Set 1: (2 inline comments) .................................................... File src/ovirtsdk/infrastructure/proxy.py Line 82: if response.status < 400: agree, this should have a few test cases for various possible errors. (and not sure if >=400 can't return a body as well in some cases) Line 86: except socket.error, e: what if another type of exception occurred (say, on parseString)? one wouldn't want the logging logic to cause the real code to stop working rather than just log there was a problem writing to the log. -- To view, visit http://gerrit.ovirt.org/3934 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82d9101ebae8197df6554992d583faacf6bc2a9d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alex Jia <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
