Daniel Erez has posted comments on this change.
Change subject: webadmin: Dont replace . with _ if error not in resources
......................................................................
Patch Set 2:
(1 comment)
Looks good, just one minor comment.
Please check 'Verified' when done..
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/ErrorTranslator.java
Line 94: ret = errors.getString(errorMsg).replace("\n",
"<br/>"); //$NON-NLS-1$ //$NON-NLS-2$
Line 95: } else {
Line 96: // The error message is not found in the errors
map, revert to original one
Line 97: // without replacement of "." with "_"
Line 98: errorMsg = errMsgCopy;
iinm, It looks like you can just move this assignment to the 'else' clause
(line 102)
Line 99: if ((isDynamicVariable(errorMsg)) ||
(!changeIfNotFound)) {
Line 100: ret = errorMsg;
Line 101: } else {
Line 102: // just a message that doesn't have a value
in the resource:
--
To view, visit http://gerrit.ovirt.org/21083
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68c8354c7fec9e8a85fbea47bd7e4586f49defdf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
