Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: Fix add host gluster uuid already exists in the db.
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
One comment on severity
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
Line 157: severities.put(AuditLogType.GLUSTER_SERVICE_STOP_FAILED,
AuditLogSeverity.ERROR);
Line 158: severities.put(AuditLogType.GLUSTER_SERVICE_RESTARTED,
AuditLogSeverity.NORMAL);
Line 159: severities.put(AuditLogType.GLUSTER_SERVICE_RESTART_FAILED,
AuditLogSeverity.ERROR);
Line 160: severities.put(AuditLogType.GLUSTER_HOST_UUID_NOT_FOUND,
AuditLogSeverity.ERROR);
Line 161: severities.put(AuditLogType.GLUSTER_HOST_UUID_ALREADY_EXISTS,
AuditLogSeverity.ERROR);
I feel the severity should be AuditLogSeverity.CONFLICT
Line 162: severities.put(AuditLogType.GLUSTER_BRICK_STATUS_CHANGED,
AuditLogSeverity.WARNING);
Line 163: }
Line 164:
Line 165: private static void initDefaultSeverities() {
--
To view, visit http://gerrit.ovirt.org/21391
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cca4c64cdbcb6a681089e1fbb2f0d707f768083
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
