Gilad Chaplik has posted comments on this change.
Change subject: engine: scheduling optimization field
......................................................................
Patch Set 6:
(4 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
Line 262: if (policy.getFunctions() == null ||
policy.getFunctions().isEmpty()) {
Line 263: return vdsList.get(0).getId();
Line 264: }
Line 265: Guid bestHost = null;
Line 266: // weigh hosts iff there are more than 1 host in case
optimize for speed
not a typo, I meant: http://en.wikipedia.org/wiki/If_and_only_if
:-) but I will change it.
Line 267: // is true and there are more than configurable requests
pending skip weighing
Line 268: if (vdsList.size() > 1
Line 269: && (!cluster.isSchedulerOptimizeForSpeed()
Line 270: ||
clusterLockMap.get(cluster.getId()).getQueueLength() <=
Line 267: // is true and there are more than configurable requests
pending skip weighing
Line 268: if (vdsList.size() > 1
Line 269: && (!cluster.isSchedulerOptimizeForSpeed()
Line 270: ||
clusterLockMap.get(cluster.getId()).getQueueLength() <=
Line 271: Config.<Integer>
GetValue(ConfigValues.OptimizeSchedulerForSpeedPendingRequests))) {
Done
Line 272: bestHost = runFunctions(policy.getFunctions(),
vdsList, vm, parameters);
Line 273: }
Line 274: if (bestHost == null && vdsList.size() > 0) {
Line 275: bestHost = vdsList.get(0).getId();
Line 284: vm.getNumOfCpus());
Line 285: }
Line 286: return bestHost;
Line 287: } catch (InterruptedException e) {
Line 288: // ignore
Done
Line 289: return null;
Line 290: } finally {
Line 291: clusterLockMap.get(cluster.getId()).release();
Line 292: }
....................................................
File
packaging/dbscripts/upgrade/03_04_1000_add_vds_group_scheduling_optimization_field.sql
Line 1: select fn_db_add_column('vds_groups', 'optimize_for_speed', 'boolean
not null default false');
Done
--
To view, visit http://gerrit.ovirt.org/19270
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0784f89648093e650be73fcc3d850a4854d53c1a
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
