Alon Bar-Lev has posted comments on this change.

Change subject: engine : Change parameter type of CommandBase
......................................................................


Patch Set 3:

(1 comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VdcParameterHelper.java
Line 2: 
Line 3: import java.util.List;
Line 4: import org.ovirt.engine.core.common.action.VdcActionParametersBase;
Line 5: 
Line 6: public class VdcParameterHelper {
yes, sound better... so people won't claim that adding parameters added that 
class... :)
Line 7: 
Line 8:     public static boolean isTaskGroupSuccess(VdcParametersMap 
parameters) {
Line 9:         boolean childrenTasksSuccess = 
parameters.<Boolean>get(CoreVdcParameters.TASK_GROUP_SUCCESS);
Line 10:         List<VdcActionParametersBase> imagesParameters = 
parameters.<List<VdcActionParametersBase>>get(CoreVdcParameters.IMAGE_PARAMETERS);


-- 
To view, visit http://gerrit.ovirt.org/21319
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c702d8f4184f08690d38902593bb4b733c69d95
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to