Allon Mureinik has posted comments on this change.
Change subject: engine-core: valueValidationFunction cleanup
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(2 inline comments)
Looks good - see two minor inline comments.
....................................................
File
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/AdGroupConditionFieldAutoCompleter.java
Line 24: for (String key : mVerbs.keySet()) {
>From what I could see, this list is never modified after the initial creation.
Consider replacing the ArrayList(1) with Collections.singeltonList()
....................................................
File
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/AdUserConditionFieldAutoCompleter.java
Line 40: for (String key : mVerbs.keySet()) {
Same comment - consider replacing the ArrayList with Collections.singletonList()
--
To view, visit http://gerrit.ovirt.org/2816
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85ce6f930834a5ba8a207345e45d088f4b9fd0ee
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
