Allon Mureinik has posted comments on this change.
Change subject: core: [rmd] BaseImagesCommand
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
Line 503: public static void GetImageChildren(Guid snapshot, List<Guid>
children) {
why is the temporary "list" required?
why not just do
children.addAll(DbFacade.getInstance().getDiskImageDAO().getAllSnapshotsForParent(snapshot))?
--
To view, visit http://gerrit.ovirt.org/3912
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I28951872600e2cd1c080007112668c04eb2a1bfa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
