Adam Litke has uploaded a new change for review.
Change subject: engine: [cleanup] Rename RunAction to runAction
......................................................................
engine: [cleanup] Rename RunAction to runAction
Backend.java:347, NM_METHOD_NAMING_CONVENTION, Priority: Low
The method name
org.ovirt.engine.core.bll.Backend.RunAction
(VdcActionType, VdcActionParametersBase)
doesn't start with a lower case letter
Methods should be verbs, in mixed case with the first letter lowercase,
with the first letter of each internal word capitalized.
Change-Id: I63cc50dcfdd85f97ee55e5bca37982c78fd5e949
Signed-off-by: Adam Litke <[email protected]>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java
M
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java
M
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResourceTest.java
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
6 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/45/21545/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
index a5f428a..54b9e5f 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
@@ -343,7 +343,7 @@
}
@Override
- public VdcReturnValueBase RunAction(VdcActionType actionType,
VdcActionParametersBase parameters) {
+ public VdcReturnValueBase runAction(VdcActionType actionType,
VdcActionParametersBase parameters) {
VdcReturnValueBase returnValue = notAllowToRunAction(actionType);
if (returnValue != null) {
return returnValue;
@@ -590,7 +590,7 @@
@Override
public VdcReturnValueBase logoff(LogoutUserParameters parameters) {
- return RunAction(VdcActionType.LogoutUser, parameters);
+ return runAction(VdcActionType.LogoutUser, parameters);
}
@Override
@@ -618,7 +618,7 @@
@Override
public VdcReturnValueBase RunAutoAction(VdcActionType actionType,
VdcActionParametersBase parameters) {
- return RunAction(actionType, parameters);
+ return runAction(actionType, parameters);
}
@Override
diff --git
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java
index cf0f87e..2a0b8de 100644
---
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java
+++
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java
@@ -10,7 +10,7 @@
import org.ovirt.engine.core.common.queries.VdcQueryType;
public interface BackendLocal {
- VdcReturnValueBase RunAction(VdcActionType actionType,
VdcActionParametersBase parameters);
+ VdcReturnValueBase runAction(VdcActionType actionType,
VdcActionParametersBase parameters);
VDSBrokerFrontend getResourceManager();
diff --git
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java
index 3102ada..67cc5ea 100644
---
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java
+++
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java
@@ -251,7 +251,7 @@
VdcActionParametersBase params)
throws BackendFailureException {
setJobOrStepId(params);
setCorrelationId(params);
- VdcReturnValueBase result = backend.RunAction(task,
sessionize(params));
+ VdcReturnValueBase result = backend.runAction(task,
sessionize(params));
if (result != null && !result.getCanDoAction()) {
backendFailure(result.getCanDoActionMessages());
} else if (result != null && !result.getSucceeded()) {
@@ -272,7 +272,7 @@
@Override
public void run() {
try {
- backend.RunAction(task, sp);
+ backend.runAction(task, sp);
} finally {
if (user != null) {
backend.logoff(sh.sessionize(new
LogoutUserParameters(user.getId())));
diff --git
a/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java
b/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java
index 4850b37..6a721ea 100644
---
a/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java
+++
b/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java
@@ -390,7 +390,7 @@
expect(result.getCanDoActionMessages()).andReturn(asList(errorMessage)).anyTimes();
setUpL10nExpectations(asList(errorMessage));
}
- expect(backend.RunAction(eq(task), eqActionParams(clz,
addSession(names), addSession(values)))).andReturn(result);
+ expect(backend.runAction(eq(task), eqActionParams(clz,
addSession(names), addSession(values)))).andReturn(result);
VdcQueryReturnValue monitorResult =
control.createMock(VdcQueryReturnValue.class);
expect(monitorResult.getSucceeded()).andReturn(success).anyTimes();
diff --git
a/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResourceTest.java
b/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResourceTest.java
index 0af5283..e63f99d 100644
---
a/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResourceTest.java
+++
b/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResourceTest.java
@@ -264,7 +264,7 @@
addSession(new String[]{}),
addSession(new
Object[]{})))).andReturn(monitorResult);
}
- expect(backend.RunAction(eq(task), eqActionParams(taskClass,
addSession(taskNames), addSession(taskValues))))
+ expect(backend.runAction(eq(task), eqActionParams(taskClass,
addSession(taskNames), addSession(taskValues))))
.andReturn(taskResult);
if (canDo && success && query != null) {
diff --git
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
index 53bf774..daab58a 100644
---
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
+++
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
@@ -128,7 +128,7 @@
return rValue;
}
- return getBackend().RunAction(actionType, params);
+ return getBackend().runAction(actionType, params);
}
@Override
--
To view, visit http://gerrit.ovirt.org/21545
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I63cc50dcfdd85f97ee55e5bca37982c78fd5e949
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
