Allon Mureinik has posted comments on this change.
Change subject: engine: Use getFileStats to retrieve iso and floppy files
......................................................................
Patch Set 5: Code-Review-1
(2 comments)
+1 on the idea, minor issue with the implementation - please see inline.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
Line 650:
Line 651: if (repoStorageDomainId != null) {
Line 652: try {
Line 653: StoragePool dc =
getStoragePoolDAO().get(repoStoragePoolId);
Line 654: if
(dc.getcompatibility_version().compareTo(Version.v3_3) > 0) {
Please don't hardcore this here, but add it to the config values.
This check should be moved to the FeatureSupported class.
Line 655: returnValue = Backend
Line 656: .getInstance()
Line 657: .getResourceManager()
Line 658:
.RunVdsCommand(VDSCommandType.GetFileStats,
Line 702:
Line 703: if (repoStorageDomainId != null) {
Line 704: try {
Line 705: StoragePool dc =
getStoragePoolDAO().get(repoStoragePoolId);
Line 706: if
(dc.getcompatibility_version().compareTo(Version.v3_3) > 0) {
here too
Line 707: returnValue = Backend
Line 708: .getInstance()
Line 709: .getResourceManager()
Line 710:
.RunVdsCommand(VDSCommandType.GetFileStats,
--
To view, visit http://gerrit.ovirt.org/21524
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I735d2c9343fe791e0890b4a6cc9f12c74462b3f0
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
