Moti Asayag has posted comments on this change.
Change subject: tools: send db unavailable notification as 'alert' not 'solved'
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java
Line 407: }
Line 408: List<EventAuditLogSubscriber> failedQueriesEventSubscribers =
new LinkedList<>();
Line 409: for (String email:emailRecipients.split(",")){
Line 410: EventAuditLogSubscriber eals = new
EventAuditLogSubscriber();
Line 411: eals.setevent_type(1);
I think using the specific MessageType.alertMessage.getEventType() will be
clearer in this case
and i'd say that modifying EventAuditLogSubscriber.event_type to an enum would
be even better, but requires much more work.
Line 412: eals.setevent_up_name("DATABASE_UNREACHABLE");
Line 413:
eals.setmethod_id(EventNotificationMethods.EMAIL.getValue());
Line 414: eals.setmethod_address(StringUtils.strip(email));
Line 415: eals.setmessage("Failed to query for notifications.
Database Connection refused.");
--
To view, visit http://gerrit.ovirt.org/21594
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d8637a7cafcafc94eef80a2286530d40f4236c0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
