Ori Liel has posted comments on this change.
Change subject: restapi: Run activate if remove bricks task is FINISHED
......................................................................
Patch Set 3:
(1 comment)
1 question inline
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResource.java
Line 289: VdcQueryType.GetGlusterVolumeById,
Line 290: new IdQueryParameters(asGuid(getVolumeId())),
Line 291: "");
Line 292:
Line 293: if (volume.getAsyncTask() != null &&
volume.getAsyncTask().getType() == GlusterTaskType.REMOVE_BRICK
Is this the most accurate check possible? You check if some bricks are being
removed in this volume. But what if you ran 'activate' action on brick A, and
in the same volume, brick B is being deleted (and not brick A)? Seems like this
would pass validation.
Line 294: && volume.getAsyncTask().getStatus() ==
JobExecutionStatus.FINISHED) {
Line 295: return stopMigrate(action);
Line 296: } else {
Line 297: Fault fault = new Fault();
--
To view, visit http://gerrit.ovirt.org/21292
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd5731b43132943a808bccae68fbcf0efaeeef89
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
