Shubhendu Tripathi has posted comments on this change.
Change subject: engine: Selecting permissions based on app mode
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDAODbFacadeImpl.java
Line 132: }
Line 133:
Line 134: @Override
Line 135: public List<permissions> getAllForEntity(Guid id, Guid userID,
boolean isFiltered) {
Line 136: Integer appMode = Config.<Integer>
GetValue(ConfigValues.ApplicationMode);
I think GetValue returns an "int" only, so no need to assign to Integer. Rather
you can assign to int type and then pass to parameter creation code.
Line 137:
Line 138: MapSqlParameterSource parameterSource =
getCustomMapSqlParameterSource()
Line 139: .addValue("id", id).addValue("user_id",
userID).addValue("is_filtered", isFiltered)
Line 140: .addValue("app_mode", appMode.intValue());
--
To view, visit http://gerrit.ovirt.org/21532
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d2d7f1c3d37ecfb66d0965bb0701f7ced6af84d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Darshan N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
