Liron Ar has posted comments on this change.
Change subject: core: Storage activation error fix
......................................................................
Patch Set 8:
(2 comments)
Please change the message also in
/home/laravot/src/ovirt-engine/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
Line 173: }
Line 174:
Line 175: protected boolean
checkStorageDomainStatusNotEqual(StorageDomainStatus status) {
Line 176: boolean returnValue = false;
Line 177: if (getStorageDomainStatus() != null &&
getStorageDomainStatus() != null) {
the same condition is checked twice
Line 178: returnValue = (getStorageDomainStatus() != status);
Line 179: if (!returnValue) {
Line 180: addStorageDomainStatusIllegalMessage();
Line 181: }
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommandTest.java
Line 62: nonInternalActionAllowed(StorageDomainStatus.InActive);
Line 63: }
Line 64:
Line 65: @Test
Line 66: public void nonInternalActiveDisallowed() {
this could be removed.
Line 67: testExecution(StorageDomainStatus.Active);
Line 68: testActionDisallowed();
Line 69: }
Line 70:
--
To view, visit http://gerrit.ovirt.org/21320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe8ad96a5bd40adb56b7a63c4ae5ef75a550e5b2
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Cheryn Tan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
