Vojtech Szocs has posted comments on this change. Change subject: branding: Allow templates to be replaced ......................................................................
Patch Set 3: Code-Review+2 Patch looks good, just one small comment - from README.branding I'm under impression that I should add this in branding.properties file: template_replace=true Whereas it should be this: welcome_replace=true (from README.branding I got the impression that template replacement is global setting for all pages, maybe I'm reading it wrong though) -- To view, visit http://gerrit.ovirt.org/21195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3376500d1ceece80132089d90174e092992d36d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
