Vitor de Lima has posted comments on this change. Change subject: core, engine: Get CD interface through osinfo ......................................................................
Patch Set 2: (1 comment) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java Line 651: OsRepository osRepository = SimpleDependecyInjector.getInstance().get(OsRepository.class); Line 652: Line 653: struct.put(VdsProperties.Type, vmDevice.getType().getValue()); Line 654: struct.put(VdsProperties.Device, vmDevice.getDevice()); Line 655: struct.put(VdsProperties.Index, "2"); // IDE slot 2 is reserved by VDSM to CDROM It is needed in order to determine the drive alias in VDSM. The problem is that the SCSI CD is on the first available address in the SCSI controller (LUN = 0), but its index is 2. VDSM then creates the "sdc" alias for the CD drive in this case, which seems wrong. I'm going to fix this, but since I am going to change this patch, do you think this kind of information (the CD drive index and its interface type) should be in the osinfo or should it be directly in the code (like I did with some addressing issues in change #18622)? Line 656: struct.put(VdsProperties.INTERFACE, Line 657: osRepository.getCdInterface(vm.getOs(), Line 658: vm.getVdsGroupCompatibilityVersion())); Line 659: -- To view, visit http://gerrit.ovirt.org/20294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I579fdcc0b6bdf7d23bd60efc33fbc4bad1595324 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
