Shireesh Anjal has posted comments on this change.

Change subject: engine: Revert Gluster User changes insert_predefined_roles
......................................................................


Patch Set 4: No score

I guess not. I had asked to make the upgrade script non-reentrant based on the 
standard guidelines. However since tihs is not a regular upgrade script (people 
may already have this data in the DB because it was earlier added in 
insert_predefined_roles.sql), maybe it should be reentrant.

--
To view, visit http://gerrit.ovirt.org/3909
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8250a33047f61708f6d90fabcfed5ad4b4580fc5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to