Tomas Jelinek has posted comments on this change.
Change subject: engine: added spice proxy to vds and vm_static
......................................................................
Patch Set 5:
(2 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
Line 73:
Line 74: private String clusterPolicyName;
Line 75:
Line 76: @HostnameOrIp(message =
"VALIDATION.VDS_GROUP.SPICE_PROXY.HOSTNAME_OR_IP",
Line 77: groups = { CreateEntity.class, UpdateEntity.class })
Just realized this validation is not correct - it has to also support
[protocol://]hostnameOrIp:[port]
Line 78: @Size(max = BusinessEntitiesDefinitions.SPICE_PROXY_ADDR_SIZE)
Line 79: private String spiceProxy;
Line 80:
Line 81: private Map<String, String> clusterPolicyProperties;
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPool.java
Line 59: private int maxAssignedVmsPerUser;
Line 60:
Line 61: public static final char MASK_CHARACTER = '?';
Line 62:
Line 63: @HostnameOrIp(message =
"VALIDATION.VM_POOLS.SPICE_PROXY.HOSTNAME_OR_IP",
Just realized this validation is not correct - it has to also support
[protocol://]hostnameOrIp:[port]
Line 64: groups = { CreateEntity.class, UpdateEntity.class })
Line 65: @Size(max = BusinessEntitiesDefinitions.SPICE_PROXY_ADDR_SIZE)
Line 66: private String spiceProxy;
Line 67:
--
To view, visit http://gerrit.ovirt.org/21518
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5dd4f5ef908464d75af6911eedf2dd053d07cb9e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
