Tomas Jelinek has posted comments on this change.
Change subject: frontend: override SPICE proxy on cluster and pool level
......................................................................
Patch Set 5:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
Line 1356: setMessage(null);
Line 1357: }
Line 1358:
Line 1359: if (getSpiceProxyEnabled().getEntity()) {
Line 1360: getSpiceProxy().validateEntity(new IValidation[] { new
HostAddressValidation() });
Just realized this validation is not correct - it has to also support
[protocol://]hostnameOrIp:[port]
Line 1361: } else {
Line 1362: getSpiceProxy().setIsValid(true);
Line 1363: }
Line 1364:
--
To view, visit http://gerrit.ovirt.org/21519
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d547a12b88e1acc8806fcab1f626b419a979742
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
