Michael Pasternak has posted comments on this change.
Change subject: restapi: Adding support for copy/move disk from disk collection.
......................................................................
Patch Set 11:
(1 comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java
Line 88: storageDomainId,
Line 89: ImageOperation.Copy);
Line 90: return doAction(VdcActionType.MoveOrCopyDisk, params, action);
Line 91: }
Line 92:
> Michael, those questions should be asked from the
> beginning not on patch set 12, but probably better later than never, right?
i was reviewing this patch only after your 10-th cycle (P/S-10), and there was
no
mention for specific use you aim for these methods (when the disk is attached
only)
> I am requested to provide these commands in different scope.
> You can apply move and copy on generic disk without being in scope of any
> particular VM or Template it exactly as you can do that from Disks tab in UI.
that's not what the description in rsdl_metadata.yaml says.
>
> The backend logic allows move for floating disks either, but copy is allowed
> for template disk only, so there is no reason to expose copy in VM scope, but
> in general scope is fine.
Line 93: @Override
Line 94: public Disk get() {
Line 95: return performGet(VdcQueryType.GetDiskByDiskId, new
IdQueryParameters(guid));
Line 96: }
--
To view, visit http://gerrit.ovirt.org/13973
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I516341d3e033a94a997ac5320312e75a5ed1576c
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
