Alon Bar-Lev has posted comments on this change.
Change subject: core: Add builder functions to create ParametersMap
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VdcParameterHelper.java
Line 7: import org.ovirt.engine.core.common.action.VdcActionType;
Line 8:
Line 9: public class VdcParameterHelper {
Line 10:
Line 11: public static VdcParametersMap buildActionParametersMap() {
shouldn't this be in CommandBase?
Line 12: return new VdcParametersMap().
Line 13: put(CoreVdcParameters.SHOULD_BE_LOGGED, true).
Line 14: put(CoreVdcParameters.TRANSACTION_OPTION,
TransactionScopeOption.Required).
Line 15: put(CoreVdcParameters.TASK_GROUP_SUCCESS, true).
Line 22: put(CoreVdcParameters.EXECUTION_INDEX, 0).
Line 23: put(CoreVdcParameters.MULTIPLE_ACTION, false);
Line 24: }
Line 25:
Line 26: public static VdcParametersMap buildQueryParametersMap() {
Shouldn't this be in QueryBase?
Line 27: return new VdcParametersMap().
Line 28: put(CoreVdcParameters.REFRESH, true).
Line 29: put(CoreVdcParameters.FILTERED, false);
Line 30: }
--
To view, visit http://gerrit.ovirt.org/21737
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie12d4f76ed68e8449e3ea24839c4360bbea93b35
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
